[PATCH] D31443: [LTO] Do not reorder global variables unnecessarily during merging

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 12:02:02 PDT 2017


> I'm happy to modify the comments to make it clear that this doesn't
> establish such a precedent. I think we all agree we don't want to enforce
> this in any way. But absent a better way of laying out data based on PGO,
> not changing the source order here - like we have always done in the past -
> is the best we can do.


No, it is not the *best* thing. It is *a* thing, and the comment
should imply that it is ok to change it at any point, for any reason.

> I think an LTO IR Pass that operate at the IR level should be OK as well.
> What’s wrong with that?

LTO operates at the same level as other passes: IR.

Cheers,
Rafael


More information about the llvm-commits mailing list