[PATCH] D31525: InstSimplify: Add a hook for shufflevector

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: lib/Analysis/InstructionSimplify.cpp:4097-4099
+  SmallVector<int, 32> Idxs;
+  for (unsigned i = 0; i != MaskNumElts; ++i)
+    Idxs.push_back(ShuffleVectorInst::getMaskValue(Mask, i));
----------------
Why do we need to copy this list of ints? Just read them with ShuffleVectorInst::getMaskValue() and set the MaskSelects0/1 flags right here.


Repository:
  rL LLVM

https://reviews.llvm.org/D31525