[PATCH] D30703: [DSE] Merge stores when the later store only writes to memory locations the early store also wrote to.

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 09:05:53 PDT 2017


dberlin added a comment.

In https://reviews.llvm.org/D30703#716674, @filcab wrote:

> In https://reviews.llvm.org/D30703#714535, @davide wrote:
>
> > Filipe, did you take a look at the work @bryant is doing? (cc: @dberlin) He's implementing a full-fledged PDSE which I expect should cover also this case (partial stores).
> >  Now, well, I'm not sure how far away is that from being ready (and probably this is something we want anyway in the meanwhile), but I think it's something you may want to look at independently.
>
>
> Thanks! I've looked at https://reviews.llvm.org/D29866 and it seems like it *might* deal with partial store merging/elimination in the future. But it's in a TODO, for now. So I think we could go ahead with this and, when PDSE grows that functionality, then remove it from here (or even just replace DSE with PDSE and we're done :-) ).
>  Thank you,
>
>   Filipe


Just FYI, i expect we're going to add it prior to first commit.
It's not that hard.

(i don't have an opinion on this patch)


https://reviews.llvm.org/D30703





More information about the llvm-commits mailing list