[PATCH] D31175: Improve TargetTransformInfo::getCFInstrCost()

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 3 08:38:42 PDT 2017


mssimpso added a comment.

In https://reviews.llvm.org/D31175#716538, @jonpa wrote:

> I would still vote for that we don't need to ask for a cost of a branch which we know will never exist in output. If we wanted to make it a rule to always make that query, we probably should pass the Instruction pointer as well, so that the cost function can differentiate between different cases or something similar.


I'm fine with that as long as you add an appropriate comment. I don't want to hold up this patch for something that's not going make a difference.


https://reviews.llvm.org/D31175





More information about the llvm-commits mailing list