[PATCH] D31559: CodeGen: BlockPlacement: Minor probability changes.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:799
   // The cost in the second case (assuming independence), given the layout:
   // BB, Succ, (C+Succ), D, Dom
+  // Let F = SuccFreq - Qin
----------------
this layout or  BB, Succ, D Dom, C+Succ ?


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:800
   // BB, Succ, (C+Succ), D, Dom
-  // is Qout + P * V + Qin * U
+  // Let F = SuccFreq - Qin
+  // is Qout + max(F, Qin) * U + min(F, Qin)
----------------
Move this line up by two lines.


================
Comment at: lib/CodeGen/MachineBlockPlacement.cpp:801
+  // Let F = SuccFreq - Qin
+  // is Qout + max(F, Qin) * U + min(F, Qin)
   // compare P + U vs Qout + P * U + Qin.
----------------
should it be 

min (Qout + F + Qin * U,  Qout + Qin + F * U)?


Repository:
  rL LLVM

https://reviews.llvm.org/D31559