[PATCH] D28680: [CodeGenPrep] move aarch64-type-promotion to CGP

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 1 10:42:52 PDT 2017


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM with a nitpick.

Also, I am guessing you'll have a follow-up patch for removing the AArch64AddressTypePromotion pass.



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4803
+    return true;
+  else {
     TPT.rollback(LastKnownGood);
----------------
No else after return statement


https://reviews.llvm.org/D28680





More information about the llvm-commits mailing list