[PATCH] D31523: [APInt] Add a public typedef for the internal type of APInt use it instead of integerPart. Make APINT_BITS_PER_WORD and APINT_WORD_SIZE public.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 08:53:42 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/Support/APInt.cpp:739
   for (int i = getNumWords()-1; i >= 0; --i) {
-    integerPart V = pVal[i];
+    uint64_t V = pVal[i];
     if (V == 0)
----------------
hans wrote:
> should this be WordType?
In the long term, yes. I chose uint64_t to be consistent with the rest of the APInt interface methods in the short term. In this patch I just wanted to use WordType in the tc static functions.


https://reviews.llvm.org/D31523





More information about the llvm-commits mailing list