[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael added inline comments.


================
Comment at: ELF/Target.cpp:379
+  //  64-ia-32-architectures-software-developer-instruction-set-reference-manual-325383.pdf)
+  if (Type == R_386_GOT32X) {
+    if ((Loc[-1] & 0xc7) != 0x5)
----------------
Why the if? Just use the existing switch.


================
Comment at: test/ELF/got32x-i386.s:9
+##  .globl ifunc
+##  .type ifunc, @function
+##  ifunc:
----------------
You don't need an ifunc for this, please simplify.


https://reviews.llvm.org/D30699