[PATCH] D31530: [ARM] Use new assembler diags for ARM

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 31 07:30:48 PDT 2017


olista01 updated this revision to Diff 93641.
olista01 retitled this revision from "[ARM] Use new assembler diags for ARM (WIP)" to "[ARM] Use new assembler diags for ARM".
olista01 added a comment.

Updated tests, the regression suite is now fully passing.

A few of the tests appear to show less-detailed error messages than before, printing "invalid instruction" rather than "invalid operand for instruction". However, these are cases where changing the operand in question would not make the instruction valid, so I think this is OK. There may be value in emitting a message when multiple operands are invalid, but that can come later.


Repository:
  rL LLVM

https://reviews.llvm.org/D31530

Files:
  lib/Target/ARM/ARM.td
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  test/MC/ARM/arm-branch-errors.s
  test/MC/ARM/basic-arm-instructions-v8.1a.s
  test/MC/ARM/basic-arm-instructions-v8.s
  test/MC/ARM/basic-thumb2-instructions-v8.s
  test/MC/ARM/cps.s
  test/MC/ARM/diagnostics.s
  test/MC/ARM/directive-arch_extension-fp.s
  test/MC/ARM/directive-arch_extension-idiv.s
  test/MC/ARM/fp-const-errors.s
  test/MC/ARM/fullfp16-neg.s
  test/MC/ARM/fullfp16-neon-neg.s
  test/MC/ARM/invalid-fp-armv8.s
  test/MC/ARM/invalid-hint-thumb.s
  test/MC/ARM/invalid-idiv.s
  test/MC/ARM/invalid-neon-v8.s
  test/MC/ARM/invalid-special-reg.s
  test/MC/ARM/ldr-pseudo-unpredictable.s
  test/MC/ARM/ldrd-strd-gnu-arm-bad-imm.s
  test/MC/ARM/lsl-zero-errors.s
  test/MC/ARM/negative-immediates-thumb1-fail.s
  test/MC/ARM/negative-immediates-thumb1.s
  test/MC/ARM/negative-immediates.s
  test/MC/ARM/neon-vld-vst-align.s
  test/MC/ARM/not-armv4.s
  test/MC/ARM/single-precision-fp.s
  test/MC/ARM/thumb-diagnostics.s
  test/MC/ARM/thumb-mov.s
  test/MC/ARM/thumb-not-mclass.s
  test/MC/ARM/thumb2-bxj-v8.s
  test/MC/ARM/thumb2-bxj.s
  test/MC/ARM/thumb2-diagnostics.s
  test/MC/ARM/thumb2-dsp-diag.s
  test/MC/ARM/thumbv7m.s
  test/MC/ARM/thumbv8m.s
  test/MC/ARM/udf-thumb-2-diagnostics.s
  test/MC/ARM/udf-thumb-diagnostics.s
  test/MC/ARM/vfp4.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31530.93641.patch
Type: text/x-patch
Size: 515105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170331/f35ba54b/attachment-0001.bin>


More information about the llvm-commits mailing list