[PATCH] D31530: [ARM] Use new assembler diags for ARM (WIP)

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

> I have no strong opinion in this particular case. I have gone with both approaches in the past, and have had mixed results with both. :)

Ok, I'll stick with the current approach for now, but keep in mind the fact that this will need to be refactored at some point in the future.

> I assume this wouldn't be enabled for the normal lowering, just assembly files/snippets, right?

Correct, this is only used when parsing textual assembly (both files and inline asm), not during code-generation from C/C++. Most of my motivating examples come from hand-written Thumb code, where there are a lot of different immediate ranges, and the assembler often just gives a "requires arm-mode" error, which is useless on a Cortex-M target that doesn't have ARM mode.


Repository:
  rL LLVM

https://reviews.llvm.org/D31530