[llvm] r299207 - Update comment for r299098 per feedback from James Henderson.
Yaron Keren via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 31 05:08:47 PDT 2017
Author: yrnkrn
Date: Fri Mar 31 07:08:45 2017
New Revision: 299207
URL: http://llvm.org/viewvc/llvm-project?rev=299207&view=rev
Log:
Update comment for r299098 per feedback from James Henderson.
Modified:
llvm/trunk/lib/Support/raw_ostream.cpp
Modified: llvm/trunk/lib/Support/raw_ostream.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/raw_ostream.cpp?rev=299207&r1=299206&r2=299207&view=diff
==============================================================================
--- llvm/trunk/lib/Support/raw_ostream.cpp (original)
+++ llvm/trunk/lib/Support/raw_ostream.cpp Fri Mar 31 07:08:45 2017
@@ -465,8 +465,7 @@ void format_object_base::home() {
static int getFD(StringRef Filename, std::error_code &EC,
sys::fs::OpenFlags Flags) {
// Handle "-" as stdout. Note that when we do this, we consider ourself
- // the owner of stdout. This means that we can do things like close the
- // file descriptor when we're done and set the "binary" flag globally.
+ // the owner of stdout and may set the "binary" flag globally based on Flags.
if (Filename == "-") {
EC = std::error_code();
// If user requested binary then put stdout into binary mode if
More information about the llvm-commits
mailing list