[PATCH] D31523: [APInt] Add a public typedef for the internal type of APInt use it instead of integerPart. Make APINT_BITS_PER_WORD and APINT_WORD_SIZE public.
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 31 01:51:40 PDT 2017
hans added a comment.
Seems reasonable to me, but Tim is more familiar with APFloat, so it would be good if he could take a look.
================
Comment at: include/llvm/ADT/APInt.h:75
+ enum : unsigned {
+ /// Byte size of a word
+ APINT_WORD_SIZE = sizeof(WordType),
----------------
ultra nit: finish comment with a period (also below).
================
Comment at: lib/Support/APInt.cpp:739
for (int i = getNumWords()-1; i >= 0; --i) {
- integerPart V = pVal[i];
+ uint64_t V = pVal[i];
if (V == 0)
----------------
should this be WordType?
https://reviews.llvm.org/D31523
More information about the llvm-commits
mailing list