[PATCH] D31249: [DAGCombiner] Add vector demanded elements support to computeKnownBitsForTargetNode

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 22:54:54 PDT 2017


bjope added a comment.

In https://reviews.llvm.org/D31249#712996, @RKSimon wrote:

> Updated after clang-format'ing AMDGPUISelLowering.cpp and adding DemandedElts to doxygen comment.
>
> I can add an assertion to the start of each computeKnownBitsForTargetNode if you think its worth it?


No, I think we can skip the asserts. I might actually have been thinking wrong about it, since it should be allowed to ignore DemandedElts (and return som known bits) even if DemandedElts is empty.


Repository:
  rL LLVM

https://reviews.llvm.org/D31249





More information about the llvm-commits mailing list