[lld] r299115 - Include filenames in error messages to report broken files.

[Rafael Espíndola via llvm-commits]

I see. Maybe pass InputFile to check and have check call getLogName()
only when needed?

Cheers,
Rafael


On 30 March 2017 at 17:46, Rui Ueyama <ruiu at google.com> wrote:
> We may be able to do that. I had a concern about the performance penalty
> because that function would be called on every check() invocation, though.
>
> On Thu, Mar 30, 2017 at 2:43 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
>>
>> On 30 March 2017 at 17:32, Rui Ueyama <ruiu at google.com> wrote:
>> > We use a different (and more spacious) format to report undefined
>> > errors:
>> > "foo.o in archive bar.a". So, probably yes.
>> >
>>
>>
>> But LogName is always created with
>>
>> F->LogName = (ArchiveName + "(" + F->LogName + ")").str();
>>
>> So we could have a getLogName() function instead of a member variable, no?
>>
>> Cheers,
>> Rafael
>
>