[PATCH] D31503: [GlobalISel]: Fix bug where we can report GISelFailure on erased instructions

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

> I considered and dismissed speculatively printing: it's a pretty expensive operation

I was expecting something like that, but I thought we could mitigate this by only pre-printing stuff in debug build. Non-debug would just fail with unable to legalize.

> Here's another idea I considered: have legalizeInstr return the instruction it failed on, in a std::pair<LegalizeResult, MachineInstr*>.

How would that work with a deleted instruction?


Repository:
  rL LLVM

https://reviews.llvm.org/D31503