[PATCH] D31037: [EarlyCSE] hoist div/rem when sibling op exists (PR31028)

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

I dunno. Does EarlyCSE do any other insertion?
I'm somewhat wary.
My general feeling is the insertion should be separate from the rest of what it does, but i understand that's hard in earlycse because it does not really produce an analysis.
I just feel weird be shoving more stuff in there :)
*especially* cost based stuff.

I'd actually feel better even if you did this in GVN or something that at least does insertion right now, even if that's not quite a great solution either.


Repository:
  rL LLVM

https://reviews.llvm.org/D31037