[PATCH] D31505: Do not close STD* descriptors

[Rafael Ávila de Espíndola via Phabricator via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Support/raw_ostream.cpp:500
   }
+  if (FD <= STDERR_FILENO)
+    ShouldClose = false;
----------------
Needs a comment explaining why we don't close them and preferably also why using dup "doesn't work" (i.e., it would still have stdout open in the end).



Repository:
  rL LLVM

https://reviews.llvm.org/D31505