[PATCH] D31169: [DAGCombiner] Initial support for the fast-math flag contract
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 30 12:06:08 PDT 2017
anemet added a comment.
In https://reviews.llvm.org/D31169#714312, @spatel wrote:
> LGTM - see a couple of small nits for the PPC test comment.
Thanks!
> Also, you can use the script at utils/update_llc_test_checks.py to auto-generate exact checks for PPC (avoid CHECK-NOT whenever possible).
Done. Please take a look at the committed version. The powerpc64le assembly looked correct to me but I don't work on PPC.
================
Comment at: test/CodeGen/PowerPC/fma-aggr-FMF.ll:15
+
+; There is no contract on the mul with no use so we can't fuse that. Since we
+; are fusing with the mul with a use, the fmul needs to stick around beside
----------------
spatel wrote:
> "no use" -> "one use"
I added the word "extra" use which is what I meant to write :)
Repository:
rL LLVM
https://reviews.llvm.org/D31169
More information about the llvm-commits
mailing list