[PATCH] D31364: LTO: Reduce memory consumption by creating an in-memory symbol table for InputFiles. NFCI.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 11:59:39 PDT 2017


mehdi_amini added a comment.

I'm fine with the approach. I didn't review in great details but I can trust @rafael.



================
Comment at: llvm/include/llvm/Object/IRSymtab.h:15
+// without needing to construct a module in memory.
+//
+// As with most object files the symbol table has two parts: the symbol table
----------------
I think it should be mentioned that the table contains the information for *multiple* modules. This is non-intuitive when someone think about a "symbol table for IR".


https://reviews.llvm.org/D31364





More information about the llvm-commits mailing list