[PATCH] D31481: Change the error message format for undefined symbols.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Error.cpp:83
 
+  if (PrevMultiline)
+    *ErrorOS << "\n";
----------------
rafael wrote:
> Maybe factor these 3 lines into a small helper method?
Done.


================
Comment at: lld/ELF/InputSection.cpp:264
+
+  // Find a function symbol that encloses a given location.
+  for (SymbolBody *B : getFile<ELFT>()->getSymbols())
----------------
rafael wrote:
> Why does it have to be a function? Don't we want the same drag when, for example, a vtable has an undefined reference?
The current code does this too, but there's probably no strong reason to do this only for functions, so I made this to find any symbol that encloses a given location.


https://reviews.llvm.org/D31481