[PATCH] D31169: [DAGCombiner] Initial support for the fast-math flag contract

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see a couple of small nits for the PPC test comment.

Also, you can use the script at utils/update_llc_test_checks.py to auto-generate exact checks for PPC (avoid CHECK-NOT whenever possible). Bonus points if you add aarch64 to the supported triples in that script and improve those checks too. :)



================
Comment at: test/CodeGen/PowerPC/fma-aggr-FMF.ll:15
+
+; There is no contract on the mul with no use so we can't fuse that.  Since we
+; are fusing with the mul with a use, the fmul needs to stick around beside
----------------
"no use" -> "one use"


================
Comment at: test/CodeGen/PowerPC/fma-aggr-FMF.ll:16
+; There is no contract on the mul with no use so we can't fuse that.  Since we
+; are fusing with the mul with a use, the fmul needs to stick around beside
+; the fma.
----------------
"a use" -> "two uses"


https://reviews.llvm.org/D31169