[PATCH] D31048: AMDGPU: Add all atomicrmw fields to atomic.inc/dec

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:253-255
+  llvm_i32_ty, // ordering
+  llvm_i32_ty, // scope
+  llvm_i1_ty], // isVolatile
----------------
kzhuravl wrote:
> atomicrmw has these fields in the following order:
> [volatile], [singlethread], <ordering>
> 
> should we mirror it in the same order?
In the text format volatile is placed before the normal pointer arguments, which I don't think we should do. It is a useful convention to keep the pointer argument first which matches loads


https://reviews.llvm.org/D31048