[PATCH] D31432: avoid a subshell

[Filipe Cabecinhas via llvm-commits]

It makes it possible to use only the internal lit shell, instead of
relying on having bash or similar.
This allows us to not hack around some POSIX tests when running tests
on the PS4 (or any other sanitizer target) from Windows. (non-POSIX
host to a POSIX target)

I would expect this to matter a bit for Android too. But of course you
can work around it by forcing external shell and always having bash or
similar.

Thank you,
 Filipe

On Thu, Mar 30, 2017 at 1:01 AM, Kostya Serebryany <kcc at google.com> wrote:
> why do we need to avoid a subshell?
>
> On Tue, Mar 28, 2017 at 12:25 PM, Rafael Ávila de Espíndola via Phabricator
> via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> rafael created this revision.
>> Herald added a subscriber: kubamracek.
>>
>> ulimit -s will impact the following commands and FileCheck better be able
>> to run with a 4MB stack :-)
>>
>>
>> https://reviews.llvm.org/D31432
>>
>> Files:
>>   compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cc
>>
>>
>> Index: compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cc
>> ===================================================================
>> --- compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cc
>> +++ compiler-rt/test/asan/TestCases/Posix/deep_call_stack.cc
>> @@ -1,6 +1,7 @@
>>  // Check that UAR mode can handle very deep recusrion.
>> -// RUN: %clangxx_asan -O2 %s -o %t && \
>> -// RUN:   (ulimit -s 4096; %env_asan_opts=detect_stack_use_after_return=1
>> %run %t) 2>&1 | FileCheck %s
>> +// RUN: %clangxx_asan -O2 %s -o %t
>> +// RUN: ulimit -s 4096
>> +// RUN: %env_asan_opts=detect_stack_use_after_return=1 %run %t 2>&1 |
>> FileCheck %s
>>
>>  // Also check that use_sigaltstack+verbosity doesn't crash.
>>  // RUN:
>> %env_asan_opts=verbosity=1:use_sigaltstack=1:detect_stack_use_after_return=1
>> %run %t  | FileCheck %s
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>