[PATCH] D31483: [DAGCombiner] convert and-of-seteq to bitwise logic+seteq (PR32401)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 30 06:40:07 PDT 2017


spatel added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3251
+    SDValue Zero = DAG.getConstant(0, DL, OpVT);
+    return DAG.getSetCC(DL, VT, Or, Zero, ISD::SETEQ);
+  }
----------------
efriedma wrote:
> If you're going to do this, it would be nice to at least handle the inverse case: or(setne, setne).  Not sure what other related cases are worth transforming.
Sure - I was planning to look at the related patterns in "visitORLike" as well as the vector cases as follow-ups. Would you prefer that I pull it together in one patch, or I can add another FIXME comment?


https://reviews.llvm.org/D31483





More information about the llvm-commits mailing list