[PATCH] D31477: [asan] Add support for running lit tests in the iOS Simulator

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

We should probably mention what the `SANITIZER_IOS_TEST_DEVICE_IDENTIFIER` and `SANITIZER_IOSSIM_TEST_DEVICE_IDENTIFIER` variables should contain, and how to get those values.



================
Comment at: test/asan/lit.cfg:110
   config.available_features.add('android')
-  clang_wrapper = os.path.join(asan_lit_source_dir,
-                               "android_commands", "android_compile.py") + " "
+  clang_wrapper = os.path.join(asan_lit_source_dir, "android_commands", "android_compile.py") + " "
 else:
----------------
Please split this cleanup into a separate change (or just commit it separately)


================
Comment at: test/asan/lit.cfg:127
+    env_wrapper = os.path.join(asan_lit_source_dir, "..", "sanitizer_common", "ios_commands", "iossim_env.py")
+    config.substitutions.remove(('%run', ''))
+    config.substitutions.append(('%run', run_wrapper))
----------------
Don't add the `%run` substitution only to remove it later, please.
It will make it harder to figure out what the actual `%run` substitution is. Adding a `if config.host_os != 'Darwin' or not config.iossim` should be enough.


================
Comment at: test/asan/lit.site.cfg.in:11
+config.ios = "@ASAN_TEST_IOS@"
+config.iossim = "@ASAN_TEST_IOSSIM@"
 config.asan_dynamic = @ASAN_TEST_DYNAMIC@
----------------
Please use `pythonize_bool` and the `_PYBOOL` versions of these.


Repository:
  rL LLVM

https://reviews.llvm.org/D31477