[PATCH] D30299: [tablegen] Optionally format tablegen targets with clang-format

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

In https://reviews.llvm.org/D30299#710519, @qcolombet wrote:

> Hi Daniel,
>
> That's interesting.
>  I am a bit concerned about making GISel special in terms of how the output looks. I can see the argument but I am also wondering if we don't what to have a control on that. For instance, in SDISel, each entry in the array is on its own line and clang-format could break that.


Is that the case for many of the files that we generate? If not, maybe we can make it opt-out instead?
Alternatively, clang-format accepts some configuration options, is there any combination of those that would make the output of SDISel look ok when clang-formatted?

> Ideally I would like we have the same (post) processing for every tablegen file but given I don't see that happening, (at least in the near future) I would lean toward properly emitting the output from the start.
> 
> Cheers,
> -Quentin




https://reviews.llvm.org/D30299