[PATCH] D31454: [XRay][compiler-rt] Use llvm-xray in FDR mode tests

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

In https://reviews.llvm.org/D31454#713302, @kpw wrote:

> LGTM
>
> 1. Do these run as part of the "check-xray" target?


Yes. :)

> 2. We should update these to set the function time threshold flag to zero when we merge the unwriting patch in.

Agreed.

> I volunteer to write a few supplemental test cases when that lands.
> 
> - Sets the threshold very high and checks that no functions appear in the log.
> - Sets the threshold high, but have some functions that sleep. Check that invocations are erased when it makes sense and remain when eligible.

Those sound like perfect individual tests to run indeed. :)


https://reviews.llvm.org/D31454