[PATCH] D31474: Update suspended threads info to be compatible with darwin

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld.h:38-39
+struct SuspendedThreadInfo {
+  SuspendedThread thread;
+  SuspendedThreadID tid;
+};
----------------
Can we use actual types here?  The typedefs are just confusing.

How about this:  The contents of this struct will be ifdef'd and use actual types (pid_t on Linux, thread_t+uptr64_t on Darwin).  The SuspendedThreadsList API below will only deal with the whole struct, i.e. GetThread returns the whole struct, GetThreadID will be removed, Contains will search for matches of the whole struct (or select one field to be the "primary id", which we'll match for).


https://reviews.llvm.org/D31474