[PATCH] D29892: ar: add llvm-dlltool support

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 15:34:00 PDT 2017


ruiu added a comment.

In https://reviews.llvm.org/D29892#713608, @martell wrote:

> In https://reviews.llvm.org/D29892#713457, @ruiu wrote:
>
> > I want to see a patch to remove code from LLD as they should be checked in as a pair with this patch.
>
>
> I can do that, my question on the parser remains to do this though because that is also mostly shared with lld bar a few tweaks?


That is an unanswered question. You are copying this large code, and if you would fail to find a good way to remove the duplicated code from LLD in a follow-up patch, we'd have two duplicate parsers, which I want to avoid. You want to find a good way to avoid duplication.


Repository:
  rL LLVM

https://reviews.llvm.org/D29892





More information about the llvm-commits mailing list