[PATCH] D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D31444#713580, @inglorion wrote:

> So the idea is to essentially force callers to supply a linkage type and a filename so that they have to think about this stuff, and then say "If you don't have a linkage type, just pass ExternalLinkage and a dummy filename"? And then always call getRealLinkageName inside getGUID to correctly handle IRNames and hope that nobody ever has a non-IR name that starts in "\x01"?


That was my thinking on the proposal. I'll let pcc and mehdi chime in on whether that's what they also had in mind.


https://reviews.llvm.org/D31444