[PATCH] D29892: ar: add llvm-dlltool support
Rafael Ávila de Espíndola via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 29 14:21:23 PDT 2017
rafael added inline comments.
================
Comment at: lib/Object/ArchiveWriter.cpp:318
+ if (Symflags & object::SymbolRef::SF_Undefined &&
+ !(Symflags & object::SymbolRef::SF_Weak))
continue;
----------------
I don't think this is correct in general. For a regular .a file I don't think the .a should include undefined weak symbols in the list.
Repository:
rL LLVM
https://reviews.llvm.org/D29892
More information about the llvm-commits
mailing list