[PATCH] D27051: [X86] Add NumRegisterParameters Module Flag

[Yaron Keren via llvm-commits]

e-mail and phab crossover.. what I meant was only moving the added code
lines to CodeGenModule::Release(), not changing the module flag mechanism
of passing the value, like this:


  if (CodeGenOpts.Autolink &&
      (Context.getLangOpts().Modules || !LinkerOptionsMetadata.empty())) {
    EmitModuleLinkOptions();
  }

*  // Record mregparm value now so it is visible through rest of codegen.*
*  if (Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86)*
*    getModule().addModuleFlag(llvm::Module::Error,
"NumRegisterParameters",*
*                              CodeGenOpts.NumRegisterParameters);*

  if (CodeGenOpts.DwarfVersion) {
    // We actually want the latest version when there are conflicts.
    // We can change from Warning to Latest if such mode is supported.
    getModule().addModuleFlag(llvm::Module::Warning, "Dwarf Version",
                              CodeGenOpts.DwarfVersion);
  }


‫בתאריך יום ד׳, 29 במרץ 2017 ב-22:54 מאת ‪Yaron Keren via Phabricator‬‏ <‪
reviews at reviews.llvm.org‬‏>:‬

> yaron.keren added a comment.
>
> No intention of any major work intended... just moved the code (locally)
> to Release and regression tests were still passing.
>
> I must be missing something - isn't the module flag is used in
> X86ISelLowering which is called after CodeGenModule::Release() is done?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D27051
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170329/ea71aaa8/attachment.html>