[PATCH] D31467: [ELF] - Detemplate GnuHashTableSection and SymbolTableSection sections.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 12:59:17 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1353
 
+void SymbolTableSection::writeTo(uint8_t *Buf) {
+  switch (Config->EKind) {
----------------
I don't think this change improves the code. You should keep this class a template class if you need something like this.


https://reviews.llvm.org/D31467





More information about the llvm-commits mailing list