[PATCH] D31359: [GlobalISel]: Allow backends to custom legalize Intrinsics

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.



>> It'd be nice if there could be a test case for the fallback mechanism in-tree for a case like this. It's not immediately obvious to me how such an in-tree test could be created at the moment.
>>  All in all, my impression so far is that patch has 2 changes:
>> 
>> 1. Having a mechanism to not blow up reportGISelFailure when a multi-step legalization fails half-way through
>> 2. Allowing custom legalization of intrinsics. If I've understood correctly, maybe best to commit them separately once there's agreement?
> 
> Yes - you are correct with the above 2 impressions.
>  Please let me know if I should create two separate reviews instead of this one.

Not needed for me to split the review in two.
Having separate commits once the patch is approved definitely is desirable.


Repository:
  rL LLVM

https://reviews.llvm.org/D31359