[PATCH] D30724: Dont emit Mapping symbols for sections that contain only data.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 29 06:36:53 PDT 2017


peter.smith added a comment.

I think the lld test in question is expecting a $d.0 mapping symbol because up to now this is what llvm-objdump has been outputting. It is not strictly necessary for the test which is checking the behaviour of the R_ARM_TARGET1 relocation in response to the --target1-rel flag. It just so happens that .text has been used for the test for what looks like convenience. Strictly speaking we would never see a R_ARM_TARGET1 relocation in an executable section (Should only be present in SHT_INIT_ARRAY or SHT_FINI_ARRAY) sections so I don't see any problem with fixing the lld test to match the new llvm-objdump output.


https://reviews.llvm.org/D30724





More information about the llvm-commits mailing list