[PATCH] D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 17:32:30 PDT 2017


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM

Please rebase to the tip of trunk / master, and I'll land once that's done. :)



================
Comment at: lib/xray/xray_fdr_logging_impl.h:312
+  // We should take the opportunity to release the buffer though.
+  auto Status = LoggingStatus.load(std::memory_order_acquire);
+  if (Status != XRayLogInitStatus::XRAY_LOG_INITIALIZED) {
----------------
You probably need to rebase, we're no longer using std::atomic<...> for these data structures.


https://reviews.llvm.org/D31384





More information about the llvm-commits mailing list