[PATCH] D31444: LTO: call getRealLinkageName on IRNames before feeding to getGUID

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D31444#712721, @inglorion wrote:

> @mehdi_amini, we have other places where we call GlobalValue::getGUID with a name that is not an IR name, e.g. in BitcodeReader.cpp. I wouldn't be opposed to moving to a design where it's harder to pass the wrong kind of name, or even a design where the IR name and the RealLinkageName and the GlobalIdentifier aren't all different things, but that is going to be a larger change. Can we get this fix in in the meantime?


Sure, it would be a separate patch (NFC) than this bugfix, I didn't mean to block this.
I don't know about windows and getRealLinkageName enough to know if this is correct and if it is the only places we need to do this, so I rather have @pcc approving this patch.

Also I'm wondering about PGO, which is also using GUIDs (maybe not impacted since the linker does not need to be involved)...


https://reviews.llvm.org/D31444