[PATCH] D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 28 07:56:16 PDT 2017
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM but if you can please strip the *.getNode() from the bool checks - they're not necessary
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1105
+ // New replace instances of N0 and N1
+ if (Replace0 && N0.getNode() && N0.getOpcode() != ISD::DELETED_NODE &&
+ NN0.getNode() && NN0.getOpcode() != ISD::DELETED_NODE) {
----------------
No need to include the .getNode() for the bool test
https://reviews.llvm.org/D31148
More information about the llvm-commits
mailing list