[PATCH] D31418: [globalisel][tablegen] Import SelectionDAG's rule predicates and support the equivalent in GIRule.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 28 03:50:35 PDT 2017


dsanders created this revision.
Herald added subscribers: igorb, kristof.beyls, dberris, rengolin, aemerson.

The SelectionDAG importer now imports rules with Predicate's attached via
Requires, PredicateControl, etc. These predicates are implemented as
bitset's to allow multiple predicates to be tested together. However,
unlike the MC layer subtarget features, each target only pays for it's own
predicates (e.g. AArch64 doesn't have 192 feature bits just because X86
needs a lot).

Both AArch64 and X86 derive at least one predicate from the MachineFunction
or Function so they must re-initialize AvailableFeatures before each
function. They also declare locals in <Target>InstructionSelector so that
computeAvailableFeatures() can use the code from SelectionDAG without
modification.

Depends on https://reviews.llvm.org/D31329


https://reviews.llvm.org/D31418

Files:
  include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  include/llvm/Target/GlobalISel/Target.td
  lib/Target/AArch64/AArch64InstructionSelector.cpp
  lib/Target/AArch64/AArch64InstructionSelector.h
  lib/Target/X86/X86InstructionSelector.cpp
  lib/Target/X86/X86InstructionSelector.h
  lib/Target/X86/X86TargetMachine.cpp
  test/TableGen/GlobalISelEmitter-GIRule.td
  test/TableGen/GlobalISelEmitter.td
  utils/TableGen/AsmMatcherEmitter.cpp
  utils/TableGen/CodeEmitterGen.cpp
  utils/TableGen/GlobalISelEmitter.cpp
  utils/TableGen/SubtargetFeatureInfo.cpp
  utils/TableGen/SubtargetFeatureInfo.h
  utils/TableGen/Types.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31418.93224.patch
Type: text/x-patch
Size: 29117 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170328/066071ff/attachment-0001.bin>


More information about the llvm-commits mailing list