[PATCH] D31354: [tsan] Assert to make sure we don't try to Acquire() or Release() a NULL pointer

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

I see that we already exclude the first page from app memory on x86_64:

  static const uptr kLoAppMemBeg   = 0x000000001000ull;

So I think a better check would be:

  CHECK(IsAppMem(addr));

It will also check for any other bogus addresses, like random values, NULL+epsilon (&null_ptr->field) and also will not duplicate mapping logic.


https://reviews.llvm.org/D31354