[PATCH] D31384: [XRay] [compiler-rt] Write buffer length to FDR log before writing buffer.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 19:17:09 PDT 2017


dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.

I think I prefer putting FDR-specific information in the padding data available for the header record. We can use more bytes in the 32-byte `XRayFileHeader` to encode the FDR log buffer size, and if you want potentially the number of buffers as well.


https://reviews.llvm.org/D31384





More information about the llvm-commits mailing list