[PATCH] D31407: [PPC] In PPCBoolRetToInt change the bool value to i64 if the target is ppc64

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 16:06:34 PDT 2017


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Couple of small nits, otherwise LGTM.

-eric



================
Comment at: lib/Target/PowerPC/PPCBoolRetToInt.cpp:91
 
   // Translate a i1 value to an equivalent i32 value:
+  Value *translate(Value *V) {
----------------
Update? 


================
Comment at: lib/Target/PowerPC/PPCBoolRetToInt.cpp:197
+    ST = nullptr;
+    if (TM)
+      ST = TM->getSubtargetImpl(F);
----------------
Let's just always assume we have a TargetMachine and return false if not?


================
Comment at: test/CodeGen/PowerPC/pr32442.ll:2
+; RUN: llc -mtriple=powerpc64le-linux-gnu -mcpu=pwr8 < %s | FileCheck %s
+
+; CHECK-NOT: clrldi
----------------
Throw the PR number in here as a comment?


https://reviews.llvm.org/D31407





More information about the llvm-commits mailing list