[PATCH] D31307: Enable builds of darwin lsan by default

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/asan/asan_flags.cc:64
     cf.CopyFrom(*common_flags());
-    cf.detect_leaks = CAN_SANITIZE_LEAKS;
+    cf.detect_leaks = CAN_SANITIZE_LEAKS && !SANITIZER_MAC;
     cf.external_symbolizer_path = GetEnv("ASAN_SYMBOLIZER_PATH");
----------------
`asan_flags.cc` currently doesn't have any platform-specific code.  Could this be moved to some `_mac.cc` file?  Or perhaps into `sanitizer_flags.inc`?

If not, then this at least deserves a comment explaining that we're bringing up LSan and it doesn't fully work yet on Darwin.


https://reviews.llvm.org/D31307