[PATCH] D30148: AMDGPU/SI: Fix listing of Low and High latency instructions

Valery Pykhtin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 27 07:26:24 PDT 2017


vpykhtin added a comment.

In https://reviews.llvm.org/D30148#686726, @axeldavy wrote:

> In https://reviews.llvm.org/D30148#682960, @arsenm wrote:
>
> > It's still missing a few. VINTRP and EXP. I think it would be better to check instruction latency data. In absence of that, I think it would be simpler to just use isHighLatencyInstruction, and !isHighLatencyInstruction
>
>
> The true usage of these helper functions is to deduce instructions which need a VMCNT wait or a LGKMCNT wait (former ones being incorrectly called 'high latency' and the latter ones 'lon latency').
>
> What about renaming to isVMCNTInstruction and isLGKMCNTInstruction ?


SIInstrInfo has helper function:

static bool usesVM_CNT(const MachineInstr &MI)

It doesn't however contains the analogue for LGKM though it can be easily added.


Repository:
  rL LLVM

https://reviews.llvm.org/D30148





More information about the llvm-commits mailing list