[PATCH] D31345: [XRay] [compiler-rt] Unwriting FDR mode buffers when functions are short.
Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 26 17:28:16 PDT 2017
kpw added a comment.
This doesn't handle Tail calls correctly. I made a bad assumption about the trampoline sequence.
with fA() calling fB() calling fC() the records will be
Enter fA()
Tail Exit fA()
Enter fB()
Tail Exit fB()
Enter fC()
Exit fC()
I was expecting records to come out
Enter fA()
Enter fB()
Enter fC()
Tail Exit fA()
I'm changing my code to handle the truth. Hold off on review until I post an update.
https://reviews.llvm.org/D31345
More information about the llvm-commits
mailing list