[PATCH] D31362: [llvm-readobj] Prefer ILT to IAT for reading COFF imports

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1442
     W.printString("Name", Name);
-    uint32_t Addr;
-    error(I.getImportLookupTableRVA(Addr));
-    W.printHex("ImportLookupTableRVA", Addr);
-    error(I.getImportAddressTableRVA(Addr));
-    W.printHex("ImportAddressTableRVA", Addr);
-    printImportedSymbols(I.imported_symbols());
+    uint32_t ImportLookupTableAddr;
+    error(I.getImportLookupTableRVA(ImportLookupTableAddr));
----------------
compnerd wrote:
> ILT would be better I think than ImportLookupTable
Will change before committing.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1445
+    W.printHex("ImportLookupTableRVA", ImportLookupTableAddr);
+    uint32_t ImportAddressTableAddr;
+    error(I.getImportAddressTableRVA(ImportAddressTableAddr));
----------------
compnerd wrote:
> IAT would be better than ImportAddressTable I think
Will change before committing.


https://reviews.llvm.org/D31362