[PATCH] D31359: [GlobalISel]: Allow backends to custom legalize Intrinsics
Ahmed Bougacha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 24 23:03:16 PDT 2017
ab added inline comments.
================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:81
}
+ Erased |= Res == Erase;
Changed |= Res == Legalized;
----------------
I don't think you want this behavior: you should only return "Erase" if you want to erase the "root"/initial MI, not any arbitrary MI in the worklist.
Thought that does raise an interesting question: what happens if you legalize an intrinsic to two new intrinsics, and you want to erase one of those? Who should be responsible for that?
Repository:
rL LLVM
https://reviews.llvm.org/D31359
More information about the llvm-commits
mailing list