[PATCH] D30299: [tablegen] Optionally format tablegen targets with clang-format

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 18:59:33 PDT 2017


qcolombet added a comment.

Hi Daniel,

That's interesting.
I am a bit concerned about making GISel special in terms of how the output looks. I can see the argument but I am also wondering if we don't what to have a control on that. For instance, in SDISel, each entry in the array is on its own line and clang-format could break that.

Ideally I would like we have the same (post) processing for every tablegen file but given I don't see that happening, (at least in the near future) I would lean toward properly emitting the output from the start.

Cheers,
-Quentin


https://reviews.llvm.org/D30299





More information about the llvm-commits mailing list