[PATCH] D31311: [DAGCombiner] Add vector demanded elements support to ComputeNumSignBits

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3148
+    // an unknown element index, ignore DemandedElts and demand them all.
+    APInt DemandedElt = APInt::getAllOnesValue(NumSrcElts);
+    ConstantSDNode *ConstEltNo = dyn_cast<ConstantSDNode>(EltNo);
----------------
RKSimon wrote:
> filcab wrote:
> > Nit: I'd use the plural (`DemandedElts`).
> Except it will cause a Wshadow problem - I can use DemandedElts maybe?
DemandedSrcElts


Repository:
  rL LLVM

https://reviews.llvm.org/D31311