[PATCH] D31290: [x86] use PMOVMSK to replace memcmp libcalls for 16-byte equality

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.h:819
+    /// Vector-sized comparisons are fast using PCMPEQ + PMOVMSK or PTEST.
+    bool hasFastEqualityCompare(EVT VT) const override;
+    
----------------
efriedma wrote:
> It probably makes sense to make this take a size in bytes, and return a VT, rather than calling this with every possible VT.
Yep - that makes the patch simpler.


https://reviews.llvm.org/D31290